Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] [ccr] add support for restore to ccr #45162

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[Enhancement] [ccr] add support for restore to ccr #45162

wants to merge 1 commit into from
+110 −5

Conversation

Vallishp
Copy link
Contributor

@Vallishp Vallishp commented Dec 8, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #43557

Related PR: #303

Problem Summary:
add support for restore to ccr
adding binlog for restore only if after restore is finished.

Release note

None

Check List (For Author)

  • Test

    • Regression test // in ccr PR
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Vallishp Vallishp marked this pull request as draft December 8, 2024 15:51
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Vallishp
Copy link
Contributor Author

Vallishp commented Dec 8, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Vallishp Vallishp marked this pull request as ready for review December 11, 2024 14:17
@Vallishp
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Vallishp Vallishp mentioned this pull request Dec 11, 2024
Open
@Vallishp
Copy link
Contributor Author

run buildall

@Vallishp
Copy link
Contributor Author

run p0

w41ter
w41ter requested changes Dec 16, 2024
View reviewed changes
fe/fe-core/src/main/java/org/apache/doris/persist/EditLog.java
@@ -1693,8 +1694,13 @@ public void logAlterRepository(Repository repo) {
logEdit(OperationType.OP_ALTER_REPOSITORY, repo);
}

public void logRestoreJob(RestoreJob job) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doris' editlog has a replay process, and the specific steps are in EditLog.loadJournal. Both the log phase and the replay phase need to add the binlog to the binlog manager. If a RestoreBinLogInfo is temporarily created in the log phase, then it will not be possible to construct RestoreBinLogInfo in the replay phase.

fe/fe-core/src/main/java/org/apache/doris/backup/RestoreBinLogInfo.java Outdated
import java.util.Map;
import java.util.stream.Collectors;

public class RestoreBinLogInfo {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider keeping consistent with the existing word Binlog.

@Vallishp Vallishp marked this pull request as draft December 18, 2024 09:23
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w41ter w41ter w41ter requested changes

@dataroaring dataroaring Awaiting requested review from dataroaring

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] add support for restore to ccr
3 participants
@Vallishp @doris-robot @w41ter